feat(e2e-test): add support for Qwen 3.5 series models#1092
feat(e2e-test): add support for Qwen 3.5 series models#1092LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
- Add Qwen3.5-Plus, Qwen3.5-Flash, and Qwen3.5-397B-A17B models to DashScopeCompatibleProvider
There was a problem hiding this comment.
Pull request overview
Adds E2E test provider coverage for the Qwen 3.5 model series on both DashScope native and DashScope OpenAI-compatible endpoints.
Changes:
- Introduces Qwen3.5-Plus, Qwen3.5-Flash, and Qwen3.5-397B-A17B provider variants (standard + multi-agent) for DashScope native API.
- Introduces the same Qwen3.5 provider variants for the DashScope OpenAI-compatible API.
- Registers the new providers in
ProviderFactoryso they participate in capability-based E2E selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| agentscope-core/src/test/java/io/agentscope/core/e2e/providers/DashScopeProvider.java | Adds DashScope-native Qwen3.5 provider classes and capability annotations. |
| agentscope-core/src/test/java/io/agentscope/core/e2e/providers/DashScopeCompatibleProvider.java | Adds DashScope OpenAI-compatible Qwen3.5 provider classes and capability annotations. |
| agentscope-core/src/test/java/io/agentscope/core/e2e/ProviderFactory.java | Registers the new Qwen3.5 providers for discovery and filtering in E2E runs. |
| /** Qwen3.5-Plus - Native multimodal model (image, video). */ | ||
| @ModelCapabilities({ | ||
| ModelCapability.BASIC, | ||
| ModelCapability.TOOL_CALLING, | ||
| ModelCapability.IMAGE, |
There was a problem hiding this comment.
The Javadoc says these Qwen3.5 models are "Native" multimodal models, but this class is the DashScope OpenAI-compatible provider. Please reword these new Javadocs to avoid implying the native DashScope API is being used (similar to the existing "via OpenAI compatible API" wording used for Qwen3-VL-Plus in this file).
| public static class Qwen35_397bA17bOpenAI extends DashScopeCompatibleProvider { | ||
| public Qwen35_397bA17bOpenAI() { | ||
| super("qwen3.5-397b-a17b", false); | ||
| } |
There was a problem hiding this comment.
The class name includes an underscore and mixes casing in the size suffix ("397bA17b"), which is inconsistent with the other provider class names in this file (none use underscores). Consider renaming to a consistent Java identifier style (e.g., no underscores and consistent "B" casing) and update ProviderFactory accordingly.
| /** | ||
| * Qwen3.5-Plus - Native multimodal model (image, video). | ||
| */ | ||
| @ModelCapabilities({ |
There was a problem hiding this comment.
Now that Qwen3.5 providers are added in this file, the class-level Javadoc that lists supported models should be updated to include the new Qwen3.5 model IDs (otherwise the documentation is outdated).
| public static class Qwen35_397bA17bDashScope extends DashScopeProvider { | ||
| public Qwen35_397bA17bDashScope() { | ||
| super("qwen3.5-397b-a17b", false); | ||
| } |
There was a problem hiding this comment.
The class name includes an underscore and uses mixed casing in the size suffix ("397bA17b"), which is inconsistent with the other provider class names in this file (none use underscores). Consider renaming to a consistent Java identifier style and update ProviderFactory references.
| providers.add(new DashScopeCompatibleProvider.Qwen35FlashOpenAI()); | ||
| providers.add(new DashScopeCompatibleProvider.Qwen35FlashMultiAgentOpenAI()); | ||
| providers.add(new DashScopeCompatibleProvider.Qwen35_397bA17bOpenAI()); | ||
| providers.add(new DashScopeCompatibleProvider.Qwen35_397bA17bMultiAgentOpenAI()); |
There was a problem hiding this comment.
ProviderFactory now references Qwen3.5 397B-A17B providers using class names with underscores/mixed casing (Qwen35_397bA17b...). If you rename those provider classes to match the naming convention used elsewhere (no underscores), please update these instantiations to keep the factory compiling and consistent.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AgentScope-Java Version
1.0.11
Description
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)